Skip to content

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Apr 12, 2022

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

notriddle and others added 14 commits April 7, 2022 11:16
When a `macro_rules! foo { ... }` invocation is compiled the name used
is `foo`, not `macro_rules!`. This is different to all other macro
invocations, and confused me when I was inserted debugging println
statements for macro evaluation.

This commit changes it to `macro_rules` (or just `macro`), which is what
I expected. There are no externally visible changes.
The `Lrc` isn't necessary, neither is the `SmallVec`. Performance is
changed negligibly, but the new code is simpler.
… r=GuillaumeGomez

rustdoc doctest: include signal number in exit status

Related to rust-lang#95601
…aks, r=petrochenkov

`parse_tt`: a few more tweaks

r? `@petrochenkov`
…r=Mark-Simulacrum

[bootstrap] Grab the right FileCheck binary for dist when cross-compiling.

Fixes rust-lang#95862

We were using the target dir for all the other LLVM tools (`llvm-config`, `llvm-ar`, etc) but the build target dir for `FileCheck`. This meant for targets which are cross-compiled, we were copying the wrong binary.
…triplett

Don't test -Cdefault-linker-libraries=yes when cross compiling.

See rust-lang#95727 (comment) and the five comments below that.

Unblocks rust-lang#95727.
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Apr 12, 2022
@m-ou-se
Copy link
Member Author

m-ou-se commented Apr 12, 2022

@bors r+ rollup=never p=4

@bors
Copy link
Collaborator

bors commented Apr 12, 2022

📌 Commit 550a510 has been approved by m-ou-se

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 12, 2022
@bors
Copy link
Collaborator

bors commented Apr 12, 2022

⌛ Testing commit 550a510 with merge 52ca603...

@bors
Copy link
Collaborator

bors commented Apr 12, 2022

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing 52ca603 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 12, 2022
@bors bors merged commit 52ca603 into rust-lang:master Apr 12, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 12, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (52ca603): comparison url.

Summary:

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count1 0 13 0 7 0
mean2 N/A 1.7% N/A -0.4% N/A
max N/A 3.0% N/A -0.6% N/A

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

@rustbot rustbot added the perf-regression Performance regression. label Apr 12, 2022
@pnkfelix
Copy link
Contributor

Visiting for weekly performance triage.

image

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Apr 20, 2022
@m-ou-se m-ou-se deleted the rollup-sdevd9b branch April 20, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants